xfs
[Top] [All Lists]

Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount

To: Lachlan McIlroy <lachlan@xxxxxxx>
Subject: Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 24 Sep 2008 10:42:26 -0400
Cc: Peter Leckie <pleckie@xxxxxxx>, xfs@xxxxxxxxxxx, xfs-dev@xxxxxxx
In-reply-to: <48D9F44A.5010601@xxxxxxx>
References: <48D9C1DD.6030607@xxxxxxx> <48D9EB8F.1070104@xxxxxxx> <48D9EF6E.8010505@xxxxxxx> <20080924074604.GK5448@disturbed> <48D9F44A.5010601@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Sep 24, 2008 at 06:03:22PM +1000, Lachlan McIlroy wrote:
> Pete clearly demonstrated to me that the sv_wait is being prematurely
> woken up when it should not be.  There may be an underlying problem or
> this could just be another peculiarity of the Linux kernel.  Either way
> Pete will continue to look into this and whatever the explanation turns
> out to be, we deperately need a way to prevent our customers from
> running into this deadlock.  Even if there is another problem lurking
> this code change is fine and if nothing else will serve as a performance
> improvement.

Folks, please at least invest half the time you spend flaming each other
into looking at underlying causes ;-)

<Prev in Thread] Current Thread [Next in Thread>