xfs
[Top] [All Lists]

Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount

To: Lachlan McIlroy <lachlan@xxxxxxx>, Peter Leckie <pleckie@xxxxxxx>, xfs@xxxxxxxxxxx, xfs-dev@xxxxxxx
Subject: Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount
From: Lachlan McIlroy <lachlan@xxxxxxx>
Date: Wed, 24 Sep 2008 18:03:22 +1000
In-reply-to: <20080924074604.GK5448@disturbed>
References: <48D9C1DD.6030607@xxxxxxx> <48D9EB8F.1070104@xxxxxxx> <48D9EF6E.8010505@xxxxxxx> <20080924074604.GK5448@disturbed>
Reply-to: lachlan@xxxxxxx
User-agent: Thunderbird 2.0.0.16 (X11/20080707)
Dave Chinner wrote:
On Wed, Sep 24, 2008 at 05:42:38PM +1000, Lachlan McIlroy wrote:
Looks good Pete.

No, it is not yet good. Pete cannot explain the underlying problem
and we need to understand if this is fixing the problem or just
changing the timing so it doesn't show up....


Pete clearly demonstrated to me that the sv_wait is being prematurely
woken up when it should not be.  There may be an underlying problem or
this could just be another peculiarity of the Linux kernel.  Either way
Pete will continue to look into this and whatever the explanation turns
out to be, we deperately need a way to prevent our customers from
running into this deadlock.  Even if there is another problem lurking
this code change is fine and if nothing else will serve as a performance
improvement.

<Prev in Thread] Current Thread [Next in Thread>