[Top] [All Lists]

Re: [PATCH 7/8] XFS: Add ail pointer into log items

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 7/8] XFS: Add ail pointer into log items
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 20 Sep 2008 16:34:43 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080919092820.GG11443@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <1221317877-8333-1-git-send-email-david@xxxxxxxxxxxxx> <1221317877-8333-8-git-send-email-david@xxxxxxxxxxxxx> <20080919092820.GG11443@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Sep 19, 2008 at 05:28:20AM -0400, Christoph Hellwig wrote:
> On Sun, Sep 14, 2008 at 12:57:56AM +1000, Dave Chinner wrote:
> > Add an xfs_ail pointer to log items so that the log items can
> > reference the AIL directly during callbacks without needed a
> > struct xfs_mount.
> Does it matter? I'd be a nice cleanup if you managed to get rid of
> li_mountp, but without that I don't quite see the point.

I haven't gone as far as removing the li_mountp yet - my intention
is to do so, but I haven't written all the patches to do it yet.

The way the li_mountp is used in some subsystems was very indirect
in some cases (e.g. in the quota code) so I wanted to look a little
more at it before deciding the best way to remove as much
indirection as possible in those cases instead of adding more. It
may be that adding xfs_mount pointers into some other structures is
needed to clean this up totally...


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>