Re: [PATCH 4/8] XFS: Allow 64 bit machines to avoid the AIL lock during

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 4/8] XFS: Allow 64 bit machines to avoid the AIL lock during flushes
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Fri, 19 Sep 2008 05:26:26 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1221317877-8333-5-git-send-email-david@xxxxxxxxxxxxx>
References:	<1221317877-8333-1-git-send-email-david@xxxxxxxxxxxxx> <1221317877-8333-5-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Sun, Sep 14, 2008 at 12:57:53AM +1000, Dave Chinner wrote:
> When copying lsn's from the log item to the inode or dquot
> flush lsn, we currently grab the AIL lock. We do this because the
> LSN is a 64 bit quantity and it needs to be read atomically.
> The lock is used to guarantee atomicity for 32 bit platforms.
> 
> Make the LSN copying a small function, and make the function
> used conditional on BITS_PER_LONG so that 64 bit machines don't
> need to take the AIL lock in these places.

Looks good.

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 8/8] XFS: Finish removing the mount pointer from the AIL API, (continued) [PATCH 8/8] XFS: Finish removing the mount pointer from the AIL API, Dave Chinner Re: [PATCH 8/8] XFS: Finish removing the mount pointer from the AIL API, Christoph Hellwig [PATCH 6/8] XFS: Given the log a pointer to the AIL, Dave Chinner Re: [PATCH 6/8] XFS: Given the log a pointer to the AIL, Christoph Hellwig Re: [PATCH 6/8] XFS: Given the log a pointer to the AIL, Dave Chinner [PATCH 3/8] XFS: move the AIl traversal over to a consistent interface, Dave Chinner Re: [PATCH 3/8] XFS: move the AIl traversal over to a consistent interface, Christoph Hellwig [PATCH 1/8] XFS: Allocate the struct xfs_ail, Dave Chinner Re: [PATCH 1/8] XFS: Allocate the struct xfs_ail, Christoph Hellwig [PATCH 4/8] XFS: Allow 64 bit machines to avoid the AIL lock during flushes, Dave Chinner Re: [PATCH 4/8] XFS: Allow 64 bit machines to avoid the AIL lock during flushes, Christoph Hellwig <= [PATCH 2/8] XFS: Use a cursor for AIL traversal., Dave Chinner Re: [PATCH 2/8] XFS: Use a cursor for AIL traversal., Christoph Hellwig Re: [PATCH 2/8] XFS: Use a cursor for AIL traversal., Dave Chinner [PATCH 5/8] XFS: Move the AIL lock into the struct xfs_ail, Dave Chinner Re: [PATCH 5/8] XFS: Move the AIL lock into the struct xfs_ail, Christoph Hellwig [PATCH 7/8] XFS: Add ail pointer into log items, Dave Chinner Re: [PATCH 7/8] XFS: Add ail pointer into log items, Christoph Hellwig Re: [PATCH 7/8] XFS: Add ail pointer into log items, Dave Chinner

Previous by Date:	Re: [PATCH 3/8] XFS: move the AIl traversal over to a consistent interface, Christoph Hellwig
Next by Date:	Re: [PATCH 5/8] XFS: Move the AIL lock into the struct xfs_ail, Christoph Hellwig
Previous by Thread:	[PATCH 4/8] XFS: Allow 64 bit machines to avoid the AIL lock during flushes, Dave Chinner
Next by Thread:	[PATCH 2/8] XFS: Use a cursor for AIL traversal., Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]