xfs
[Top] [All Lists]

Re: [PATCH 3/8] XFS: move the AIl traversal over to a consistent interfa

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/8] XFS: move the AIl traversal over to a consistent interface
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 19 Sep 2008 05:26:05 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1221317877-8333-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1221317877-8333-1-git-send-email-david@xxxxxxxxxxxxx> <1221317877-8333-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Sep 14, 2008 at 12:57:52AM +1000, Dave Chinner wrote:
> With the new cursor interface, it makes sense to make all the
> traversing code use the cursor interface and make the old one go
> away. This means more of the AIL interfacing is done by passing
> struct xfs_ail pointers around the place instead of struct
> xfs_mount pointers.
> 
> We can replace the use of xfs_trans_first_ail() in
> xfs_log_need_covered() as it is only checking if the AIL is empty.
> We can do that with a call to xfs_trans_ail_tail() instead, where a
> zero LSN returned indicates and empty AIL...

Looks good.

<Prev in Thread] Current Thread [Next in Thread>