| To: | lachlan@xxxxxxx |
|---|---|
| Subject: | Re: [PATCH] xail idbg command doesn't increment count in each loop |
| From: | Timothy Shimmin <tes@xxxxxxx> |
| Date: | Fri, 19 Sep 2008 14:19:43 +1000 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx> |
| In-reply-to: | <48D31095.908@xxxxxxx> |
| References: | <48D31095.908@xxxxxxx> |
| User-agent: | Thunderbird 2.0.0.16 (Macintosh/20080707) |
Lachlan McIlroy wrote:
> count is never incremented on each log item because it is unreachable code.
>
> --- a/fs/xfs/xfsidbg.c 2008-09-19 12:27:05.000000000 +1000
> +++ b/fs/xfs/xfsidbg.c 2008-09-16 12:34:12.000000000 +1000
> @@ -6249,8 +6249,8 @@ xfsidbg_xaildump(xfs_mount_t *mp)
> default:
> kdb_printf("Unknown item type %d\n", lip->li_type);
> break;
> - count++;
> }
> + count++;
> }
> }
Oops - count++ after break.
Looks good.
--Tim
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Unlock inode before calling xfs_idestroy(), Timothy Shimmin |
|---|---|
| Next by Date: | Re: REVIEW: Fix for incore extent corruption., Eric Sandeen |
| Previous by Thread: | [PATCH] xail idbg command doesn't increment count in each loop, Lachlan McIlroy |
| Next by Thread: | [PATCH V2] Fix buffer flag definitions for xbp idbg command, Lachlan McIlroy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |