xfs
[Top] [All Lists]

Re: [PATCH V2] Fix buffer flag definitions for xbp idbg command

To: lachlan@xxxxxxx
Subject: Re: [PATCH V2] Fix buffer flag definitions for xbp idbg command
From: Timothy Shimmin <tes@xxxxxxx>
Date: Fri, 19 Sep 2008 13:40:15 +1000
Cc: xfs-oss <xfs@xxxxxxxxxxx>, xfs-dev <xfs-dev@xxxxxxx>
In-reply-to: <48D312BF.5000208@xxxxxxx>
References: <48D312BF.5000208@xxxxxxx>
User-agent: Thunderbird 2.0.0.16 (Macintosh/20080707)
Lachlan McIlroy wrote:
> PARTIAL no longer exists
> NONE is actually DONE
> FS_DATAIOD no longer exists
> FORCEIO no longer exists
> FLUSH is actually ORDERED
> DIRECTIO no longer exists
> KMEM_ALLOC is actually PAGES
> PRIVATE_BH no longer exists
> PAGE_LOCKED is a new flag
> 
> --- a/fs/xfs/xfsidbg.c    2008-09-19 12:29:57.000000000 +1000
> +++ b/fs/xfs/xfsidbg.c    2008-09-16 12:34:12.000000000 +1000
> @@ -1925,11 +1925,11 @@ static int    kdbm_iptraceaddr(
> 
> 
> static char    *bp_flag_vals[] = {
> -/*  0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
> -/*  5 */ "NONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
> -/* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
> -/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC",
> "RUN_QUEUES",
> -/* 20 */ "PRIVATE_BH", "DELWRI_Q",
> +/*  0 */ "READ", "WRITE", "MAPPED", "<unknown(3)>", "ASYNC",
> +/*  5 */ "DONE", "DELWRI",  "STALE", "FS_MANAGED", "<unknown(9)>",
> +/* 10 */ "<unknown(10)>", "ORDERED", "READ_AHEAD", "<unknown(13)>",
> "LOCK",
> +/* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "PAGES", "RUN_QUEUES",
> +/* 20 */ "<unknown(20)>", "DELWRI_Q", "PAGE_LOCKED",
>      NULL };
> 
> static char    *iomap_flag_vals[] = {

Looks good. Thanks.

--Tim

<Prev in Thread] Current Thread [Next in Thread>