Re: [PATCH 6/6] move XFS_BMAP_SANITY

xfs

Re: [PATCH 6/6] move XFS_BMAP_SANITY_CHECK out of line

To:	Christoph Hellwig <hch@xxxxxx>
Subject:	Re: [PATCH 6/6] move XFS_BMAP_SANITY_CHECK out of line
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Tue, 16 Sep 2008 16:31:46 +1000
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20080915004703.GG12213@xxxxxx>
Mail-followup-to:	Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
References:	<20080915004703.GG12213@xxxxxx>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Mon, Sep 15, 2008 at 02:47:03AM +0200, Christoph Hellwig wrote:
> Move the XFS_BMAP_SANITY_CHECK macro out of line and make it a properly typed
> function.  Also pass the xfs_buf for the btree block instead of just the btree
> block header, as we will need some additional information for it to implement
> CRC checking of btree blocks.

Looks good.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 6/6] move XFS_BMAP_SANITY_CHECK out of line, Christoph Hellwig Re: [PATCH 6/6] move XFS_BMAP_SANITY_CHECK out of line, Dave Chinner <= [PATCH 6/6] move XFS_BMAP_SANITY_CHECK out of line, Christoph Hellwig

Previous by Date:	Re: [PATCH] Fix use-after-free with log and quotas, Lachlan McIlroy
Next by Date:	Re: [PATCH 5/6] always use struct xfs_btree_block instead of short / longform structures, Dave Chinner
Previous by Thread:	[PATCH 6/6] move XFS_BMAP_SANITY_CHECK out of line, Christoph Hellwig
Next by Thread:	[PATCH 6/6] move XFS_BMAP_SANITY_CHECK out of line, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]