xfs
[Top] [All Lists]

Re: [PATCH 3/6] XFS: rename inode reclaim functions

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] XFS: rename inode reclaim functions
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 16 Sep 2008 14:27:53 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080915211400.GE29743@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <1221315300-30336-1-git-send-email-david@xxxxxxxxxxxxx> <1221315300-30336-4-git-send-email-david@xxxxxxxxxxxxx> <20080915211400.GE29743@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Sep 15, 2008 at 05:14:00PM -0400, Christoph Hellwig wrote:
> On Sun, Sep 14, 2008 at 12:14:57AM +1000, Dave Chinner wrote:
> > The function names xfs_finish_reclaim and xfs_finish_reclaim_all
> > are not very descriptive of what they are reclaiming. Rename to
> > xfs_reclaim_inode[s] to match the xfs_sync_inodes() function.
> 
> Looks good, but in case you respin the series I'd move to this to
> number two in the series.

I can do that, though I'm getting pretty sick of this whole patch
set by now....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>