xfs
[Top] [All Lists]

Re: [PATCH 3/6] XFS: rename inode reclaim functions

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] XFS: rename inode reclaim functions
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 15 Sep 2008 17:14:00 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1221315300-30336-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1221315300-30336-1-git-send-email-david@xxxxxxxxxxxxx> <1221315300-30336-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Sep 14, 2008 at 12:14:57AM +1000, Dave Chinner wrote:
> The function names xfs_finish_reclaim and xfs_finish_reclaim_all
> are not very descriptive of what they are reclaiming. Rename to
> xfs_reclaim_inode[s] to match the xfs_sync_inodes() function.

Looks good, but in case you respin the series I'd move to this to
number two in the series.

<Prev in Thread] Current Thread [Next in Thread>