xfs
[Top] [All Lists]

Re: [PATCH 1/3] XFS: factor xfs_iget_core() into hit and miss cases

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/3] XFS: factor xfs_iget_core() into hit and miss cases
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 15 Sep 2008 17:12:10 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1221314627-29065-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1221314627-29065-1-git-send-email-david@xxxxxxxxxxxxx> <1221314627-29065-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Sep 14, 2008 at 12:03:45AM +1000, Dave Chinner wrote:
> There are really two cases in xfs_iget_core(). The first is the
> cache hit case, the second is the miss case. They share very little
> code, and hence can easily be factored out into separate functions.
> This makes the code much easier to understand and subsequently
> modify.

Looks good.

<Prev in Thread] Current Thread [Next in Thread>