| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 3/3] XFS: Never call mark_inode_dirty_sync() directly |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Mon, 15 Sep 2008 17:11:36 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1221314627-29065-4-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1221314627-29065-1-git-send-email-david@xxxxxxxxxxxxx> <1221314627-29065-4-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Sun, Sep 14, 2008 at 12:03:47AM +1000, Dave Chinner wrote: > Once the Linux inode and the XFS inode are combined, we cannot rely > on just check if the linux inode exists as a method of determining > if it is valid or not. Hence we should always call > xfs_mark_inode_dirty_sync() instead as it does the correct checks to > determine if the liinux inode is in a valid state or not. Looks good. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/3] XFS: Make use of the init-once slab optimisation., Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 1/3] XFS: factor xfs_iget_core() into hit and miss cases, Christoph Hellwig |
| Previous by Thread: | [PATCH 3/3] XFS: Never call mark_inode_dirty_sync() directly, Dave Chinner |
| Next by Thread: | [PATCH 2/3] XFS: Make use of the init-once slab optimisation., Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |