xfs
[Top] [All Lists]

Re: [PATCH 0/10] XFS: clean up sync code

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 0/10] XFS: clean up sync code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 14 Sep 2008 09:24:34 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1221314230-28618-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1221314230-28618-1-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Sep 13, 2008 at 11:57:00PM +1000, Dave Chinner wrote:
> xfs_sync and xfs_syncsub are multiplexed interfaces that
> shares relatively little code between callers. because it is
> a multiplexed interface, it's hard to tell what is executed
> in each context it is called.
> 
> Factor out the sync code and explicitly call the sync functions
> needed rather than the multiplexed interfaces. Once this is
> done, we can remove xfs_syncsub and xfs_sync altogether.

The whole series looks good to me.

<Prev in Thread] Current Thread [Next in Thread>