xfs
[Top] [All Lists]

Re: [PATCH 05/10] XFS: xfssyncd: don't call xfs_sync

To: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 05/10] XFS: xfssyncd: don't call xfs_sync
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 14 Sep 2008 06:35:49 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080913165856.GB17721@xxxxxxxxxxxxxx>
Mail-followup-to: Josef 'Jeff' Sipek <jeffpc@xxxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <1221314230-28618-1-git-send-email-david@xxxxxxxxxxxxx> <1221314230-28618-6-git-send-email-david@xxxxxxxxxxxxx> <20080913165856.GB17721@xxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Sep 13, 2008 at 12:58:56PM -0400, Josef 'Jeff' Sipek wrote:
> On Sat, Sep 13, 2008 at 11:57:05PM +1000, Dave Chinner wrote:
> ...
> > @@ -533,8 +538,15 @@ xfs_sync_worker(
> >  {
> >     int             error;
> >  
> > -   if (!(mp->m_flags & XFS_MOUNT_RDONLY))
> > -           error = xfs_sync(mp, SYNC_FSDATA | SYNC_BDFLUSH | SYNC_ATTR);
> > +   if (!(mp->m_flags & XFS_MOUNT_RDONLY)) {
> > +           xfs_log_force(mp, (xfs_lsn_t)0, XFS_LOG_FORCE);
> > +           xfs_finish_reclaim_all(mp, 1, XFS_IFLUSH_DELWRI_ELSE_ASYNC);
> > +           /* dgc: errors ignored here */
> 
> Again, why?

Same again. No context for returning an error to someone useful,
and will only fail in a shutdown situation.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>