Re: [PATCH 05/10] XFS: xfssyncd: don't call xfs_sync

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Sat, Sep 13, 2008 at 12:58:56PM -0400, Josef 'Jeff' Sipek wrote:
> On Sat, Sep 13, 2008 at 11:57:05PM +1000, Dave Chinner wrote:
> ...
> > @@ -533,8 +538,15 @@ xfs_sync_worker(
> >  {
> >     int             error;
> >  
> > -   if (!(mp->m_flags & XFS_MOUNT_RDONLY))
> > -           error = xfs_sync(mp, SYNC_FSDATA | SYNC_BDFLUSH | SYNC_ATTR);
> > +   if (!(mp->m_flags & XFS_MOUNT_RDONLY)) {
> > +           xfs_log_force(mp, (xfs_lsn_t)0, XFS_LOG_FORCE);
> > +           xfs_finish_reclaim_all(mp, 1, XFS_IFLUSH_DELWRI_ELSE_ASYNC);
> > +           /* dgc: errors ignored here */
> 
> Again, why?

Same again. No context for returning an error to someone useful,
and will only fail in a shutdown situation.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx