[Top] [All Lists]

Re: [PATCH] use generic_file_llseek for directories

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] use generic_file_llseek for directories
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 12 Sep 2008 10:47:07 +0200
In-reply-to: <20080814204817.GA19614@xxxxxx>
References: <20080814204817.GA19614@xxxxxx>
User-agent: Mutt/1.3.28i
On Thu, Aug 14, 2008 at 10:48:17PM +0200, Christoph Hellwig wrote:
> XFS currently doesn't set up a .llseek for directories and thus defaults
> to default_llseek.  default_llseek only takes the BKL which means there
> is not exclusion vs xfs_readdir and thus we get a risk of corrupting
> the file position.  Additionally default_llseek only allows seeks to
> 32bit offsets by default.

Al put this change into mainline as part of fixing up various
filesystems in the meantime.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] use generic_file_llseek for directories, Christoph Hellwig <=