[Top] [All Lists]

Re: REVIEW: Improve caching in libxfs

To: Barry Naujok <bnaujok@xxxxxxx>
Subject: Re: REVIEW: Improve caching in libxfs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 4 Sep 2008 14:40:14 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
In-reply-to: <op.ugx0d0i83jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <op.ugv7ekj83jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080903234758.GA18368@xxxxxxxxxxxxx> <op.ugx0d0i83jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Sep 04, 2008 at 04:02:14PM +1000, Barry Naujok wrote:
>> Assert that we don't put a node that's already on the mru list, okay.
>> Shouldn't this be ASSERT?
> I chose to make this always abort as it can be triggered outside of
> libxfs by xfsprogs usage of it (ie. doing a "put" on a buffer that has
> already been "put").
> So, I thought this needs to always work, debug or non-debug and
> halt immediately if it happens.

Ok, makes sense.

<Prev in Thread] Current Thread [Next in Thread>