xfs
[Top] [All Lists]

Re: REVIEW: Zero rest of superblock sector always

To: Barry Naujok <bnaujok@xxxxxxx>
Subject: Re: REVIEW: Zero rest of superblock sector always
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Sep 2008 08:18:44 -0400
Cc: "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
In-reply-to: <op.ugv7zt013jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <op.ugv7zt013jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Sep 03, 2008 at 04:51:19PM +1000, Barry Naujok wrote:
> I found that zeroing the "garbage" beyond the end of the superblock in
> the first sector of each AG rather inconsistant. It depended on some
> obscure combination of version bits to be set.
>
> The following code zeroes the unused portion of all superblocks if
> there is any garbage at all in them.

Looks good.  And we'll always need the rest of the sector zeroed once
the superblock grows a crc field.

<Prev in Thread] Current Thread [Next in Thread>