xfs
[Top] [All Lists]

Re: [PATCH] buffer flag NONE is actually DONE

To: lachlan@xxxxxxx
Subject: Re: [PATCH] buffer flag NONE is actually DONE
From: Timothy Shimmin <tes@xxxxxxx>
Date: Tue, 02 Sep 2008 17:04:04 +1000
Cc: xfs-dev <xfs-dev@xxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <48BCC8C2.7040103@xxxxxxx>
References: <48BCC8C2.7040103@xxxxxxx>
User-agent: Thunderbird 2.0.0.16 (Macintosh/20080707)
Lachlan McIlroy wrote:
> Amazing but true.
> 
> --- a/fs/xfs/xfsidbg.c    2008-09-02 14:52:11.000000000 +1000
> +++ b/fs/xfs/xfsidbg.c    2008-09-02 14:51:04.000000000 +1000
> @@ -1926,7 +1926,7 @@ static int    kdbm_iptraceaddr(
> 
> static char    *bp_flag_vals[] = {
> /*  0 */ "READ", "WRITE", "MAPPED", "PARTIAL", "ASYNC",
> -/*  5 */ "NONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
> +/*  5 */ "DONE", "DELWRI",  "STALE", "FS_MANAGED", "FS_DATAIOD",
> /* 10 */ "FORCEIO", "FLUSH", "READ_AHEAD", "DIRECTIO", "LOCK",
> /* 15 */ "TRYLOCK", "DONT_BLOCK", "PAGE_CACHE", "KMEM_ALLOC", "RUN_QUEUES",
> /* 20 */ "PRIVATE_BH", "DELWRI_Q",

Looks good.

Quick look at possible mismatching names:

11 "FLUSH" vs "ORDERED"
18 "KMEM_ALLOC" vs "PAGES"
22 NULL vs "PAGE_LOCKED"

--Tim

<Prev in Thread] Current Thread [Next in Thread>