Re: [PATCH v2] Use atomic_t and wait_event to track dquot pincount

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Thu, Sep 25, 2008 at 11:03:18AM +1000, Dave Chinner wrote:
> This is a similar situation - if the sv_t is broken, we need to
> replace all users, not just work around one symptom of the
> brokenness. This is expecially important as the remaining users
> of sv_t's are in the log for iclog synchronisation....

The sv_t is not broken per se but a quite dangerous primitive as
people can easily miss re-checking the condition after a wakeup.

After a quick check 5 out of 10 callers of sv_wait re-check their
condition, and most do in a quite broad loop.  It might make sense
to just that lille bit of code and use prepare_wait / finish_wait
explicitly.