Re: [PATCH] Remove xfs_iext_irec_compact_full()

[Mark Goodwin <markgw@xxxxxxx>]

Eric Sandeen wrote:
> Lachlan McIlroy wrote:
> > Yet another bug was found in xfs_iext_irec_compact_full() and while the
> > source of the bug was found it wasn't an easy task to track it down because
> > the conditions are very difficult to reproduce.  Code that is difficult to
> > reach is difficult to test and debug.
>
> It might be nice to give credit to those who helped find it in the commit ;)

yes, this is a very significant bug to find, thanks.

I'm wondering whether it would be worth auditing or re-reviewing the entire
incore-extents-optimization patchset (if that's possible against the current
code base). Or should we just fix this and move on - let the testing 
speak for
itself? The hard to hit code paths are a worry IMO.

Cheers
-- Mark