xfs
[Top] [All Lists]

Re: [REVIEW #2] Update kernel code to compile in userspace (libxfs)

To: Barry Naujok <bnaujok@xxxxxxx>
Subject: Re: [REVIEW #2] Update kernel code to compile in userspace (libxfs)
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 1 Sep 2008 01:00:45 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx>
In-reply-to: <op.ugsdamyd3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <op.ugmy3u2o3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <op.ugm1ttzb3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080829181120.GA9455@xxxxxxxxxxxxx> <op.ugr4zpyv3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080901015950.GA16825@xxxxxxxxxxxxx> <op.ugr5hsao3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080901020826.GA31724@xxxxxxxxxxxxx> <op.ugsdamyd3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
> --- 2.6.x-xfs.orig/fs/xfs/xfs_ag.h
> +++ 2.6.x-xfs/fs/xfs/xfs_ag.h
> @@ -192,15 +192,16 @@ typedef struct xfs_perag
>       xfs_agino_t     pagi_freecount; /* number of free inodes */
>       xfs_agino_t     pagi_count;     /* number of allocated inodes */
>       int             pagb_count;     /* pagb slots in use */
> +     xfs_perag_busy_t *pagb_list;    /* unstable blocks */
>  #ifdef __KERNEL__
>       spinlock_t      pagb_lock;      /* lock for pagb_list */
> -#endif
> -     xfs_perag_busy_t *pagb_list;    /* unstable blocks */
> +

Inside structures we should be more careful about reordering,
but this one looks fine becaus pagb_list and pagb_lock should
be in the same cache line either way.

The rest looks good, too.


<Prev in Thread] Current Thread [Next in Thread>