| To: | Barry Naujok <bnaujok@xxxxxxx> |
|---|---|
| Subject: | Re: [REVIEW #2] Update kernel code to compile in userspace (libxfs) |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Sun, 31 Aug 2008 22:08:27 -0400 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, "xfs@xxxxxxxxxxx" <xfs@xxxxxxxxxxx> |
| In-reply-to: | <op.ugr5hsao3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| References: | <op.ugmy3u2o3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <op.ugm1ttzb3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080829181120.GA9455@xxxxxxxxxxxxx> <op.ugr4zpyv3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20080901015950.GA16825@xxxxxxxxxxxxx> <op.ugr5hsao3jf8g2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Mon, Sep 01, 2008 at 12:06:54PM +1000, Barry Naujok wrote: >> Looks good. >> > > What about the rest ;) Same comments apply - looks good except that in a few places less ifdef blocks would be nice. But we can do thes later if this helps you. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [REVIEW #2] Update kernel code to compile in userspace (libxfs), Barry Naujok |
|---|---|
| Next by Date: | TAKE 967805 - xfsprogs.pot file is not built if src file deleted and po/Makefile not updated, Barry Naujok |
| Previous by Thread: | Re: [REVIEW #2] Update kernel code to compile in userspace (libxfs), Barry Naujok |
| Next by Thread: | Re: [REVIEW #2] Update kernel code to compile in userspace (libxfs), Barry Naujok |
| Indexes: | [Date] [Thread] [Top] [All Lists] |