Re: [REVIEW #2] Update kernel code to compile in userspace (libxfs)

["Barry Naujok" <bnaujok@xxxxxxx>]

On Mon, 01 Sep 2008 11:59:50 +1000, Christoph Hellwig <hch@xxxxxxxxxxxxx>  
wrote:
> On Mon, Sep 01, 2008 at 11:56:03AM +1000, Barry Naujok wrote:
> > On Sat, 30 Aug 2008 04:11:20 +1000, Christoph Hellwig  
> > <hch@xxxxxxxxxxxxx>
> > wrote:
> >
> > > On Fri, Aug 29, 2008 at 05:59:43PM +1000, Barry Naujok wrote:
> > > > On Fri, 29 Aug 2008 17:00:56 +1000, Barry Naujok <bnaujok@xxxxxxx>
> > > > wrote:
> > > >
> > > > > Mostly header changes associated with #ifdef __KERNEL__ stuff.
> > > > >
> > > > > Some function prototypes had to be reordered to separate
> > > > > shared and kernel only functions.
> > > > fs/xfs/xfs_inode.h patch looked pretty horrid (and there was a missing
> > > > declaration), here's a better version:
> > > I still don't like it very much :)  What about just moving the
> > > xfs_ictimestamp and xfs_icdinode defintions next to the ifork
> > > so that we can save one ifdef __KERNEL__?  Also might be worth
> > > to move the xfs_iflock & co inlines before the end of that __KERNEL__
> > > block to save another ifdef.
> > Ok, this now only has one blob of #ifdef __KERNEL__ in it now:
> Looks good.
What about the rest ;)