xfs
[Top] [All Lists]

Re: [PATCH 4/7] XFS: Never call mark_inode_dirty_sync() directly

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/7] XFS: Never call mark_inode_dirty_sync() directly
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 18 Aug 2008 10:19:35 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080814194702.GB12237@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <1218698083-11226-1-git-send-email-david@xxxxxxxxxxxxx> <1218698083-11226-5-git-send-email-david@xxxxxxxxxxxxx> <20080814194702.GB12237@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Aug 14, 2008 at 03:47:02PM -0400, Christoph Hellwig wrote:
> On Thu, Aug 14, 2008 at 05:14:40PM +1000, Dave Chinner wrote:
> > Once the Linux inode and the XFS inode are combined, we cannot rely
> > on just check if the linux inode exists as a method of determining
> > if it is valid or not. Hence we should always call
> > xfs_mark_inode_dirty_sync() instead as it does the correct checks to
> > determine if the liinux inode is in a valid state or not.
> 
> Makes sense, and another candidate to put at the beginning of the series
> or rather just put in now.

Ok. I'll reorder it...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>