xfs
[Top] [All Lists]

TAKE 985710 - stop rejecting options in remount

To: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Subject: TAKE 985710 - stop rejecting options in remount
From: tes@xxxxxxx (Tim Shimmin)
Date: Fri, 15 Aug 2008 17:39:58 +1000 (EST)
Sender: xfs-bounce@xxxxxxxxxxx
Fix regression introduced by previous remount fixup (pv#983964) - so options 
will
no longer wrongly be rejected on remount.

Logically we would return an error in xfs_fs_remount code
to prevent users from believing they might have changed
mount options using remount which can't be changed.

But unfortunately mount(8) adds all options from
mtab and fstab to the mount arguments in some cases
so we can't blindly reject options, but have to
check for each specified option if it actually
differs from the currently set option and only
reject it if that's the case.

Until that is implemented we return success for
every remount request, and silently ignore all
options that we can't actually change.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Date:  Fri Aug 15 17:33:44 AEST 2008
Workarea:  chook.melbourne.sgi.com:/build/tes/2.6.x-xfs-quilt
Inspected by:  hch@xxxxxx

The following file(s) were checked into:
  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb


Modid:  xfs-linux-melb:xfs-kern:31908a
fs/xfs/linux-2.6/xfs_super.c - 1.447 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/linux-2.6/xfs_super.c.diff?r1=text&tr1=1.447&r2=text&tr2=1.446&f=h
        - fix remount regression


<Prev in Thread] Current Thread [Next in Thread>
  • TAKE 985710 - stop rejecting options in remount, Tim Shimmin <=