xfs
[Top] [All Lists]

Re: [PATCH] Fix reference counting race on log buffers

To: Lachlan McIlroy <lachlan@xxxxxxx>
Subject: Re: [PATCH] Fix reference counting race on log buffers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 14 Aug 2008 21:28:07 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <48A4DB09.7020702@xxxxxxx>
References: <1215752481-6862-1-git-send-email-david@xxxxxxxxxxxxx> <20080814180603.GA3087@xxxxxxxxxxxxx> <48A4DB09.7020702@xxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Aug 15, 2008 at 11:25:29AM +1000, Lachlan McIlroy wrote:
> Christoph Hellwig wrote:
>> Btw, while this patch made it to mainline it never went into the oss
>> cvs tree (and thus probably the ptools tree).
>>
>> There also are a lot of other difference between the trees, I'll see
>> how to get them back into sync..
>
> Yeah, we're aware of these differences and we're trying to sync them up.
> If you identify any specific commits from mainline (other than this log
> race fix) that aren't in the cvs tree please let us know.

I think I have most of them covered:

 - log reace
 - the endianess helpers patch I sent a note out about
 - the mnt_want_write patches I've sent today
 - just yesterday the creds preparation in mainline replaced some
   XFS current_* macros with generic ones, I'll send a patch for these
   once the changes in mainline have settled a little

The long term differences are:

 - a different xfs_version.h - IMHO we should just kill this versioning
   scheme completely..
 - xfsidbg.  Maybe now with kgdb in the kgdb folks get something
   submitted and then this is taken care off..
 - modular quota.  IMHO we should just stop doing this in CVS, it
   doesn't really buy us anything.  If people are okay with that
   I'll send a patch
 - dmapi - well, this won't get merged and currently I don't see anyone
   doing HSM for mainline properly.  But I have some ideas how to make
   it less intrusive at least

Other than that there are some difference dueto a different base kernel
version, which are temporary until the XFS tree is merged up to kernel
including those.


<Prev in Thread] Current Thread [Next in Thread>