[Top] [All Lists]

Re: [PATCH 1/6] XFS: move sync code to its own file

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/6] XFS: move sync code to its own file
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 14 Aug 2008 16:15:03 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080813140129.GC4896@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <1218505571-27588-1-git-send-email-david@xxxxxxxxxxxxx> <1218505571-27588-2-git-send-email-david@xxxxxxxxxxxxx> <20080813140129.GC4896@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Aug 13, 2008 at 10:01:29AM -0400, Christoph Hellwig wrote:
> On Tue, Aug 12, 2008 at 11:46:06AM +1000, Dave Chinner wrote:
> > The sync code in XFS is spread around several files.
> > While it used to make sense to have such a distribution,
> > the code about to be cleaned up and so centralising it
> > in one spot as the first step mackes sense.
> Besides the move you also change xfs_quiesce_fs to call xfs_sync instead
> of xfs_syncsub.  This does and additional XFS_QM_DQSYNC and an
> xfs_filestream_flush.  The latter doesn't have any effect because we
> don't have SYNC_IOWAIT set here, but the former means we are now doing
> a synchronous quota sync.  I don't think that can be harmful, but I'd be
> better left for a separate and properly documented patch.

Ok, I'll export xfs_syncsub() as well (which I was trying to avoid)
and revert that change....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>