xfs
[Top] [All Lists]

Re: [PATCH 4/6] Replace inode flush semaphore with a completion

To: Daniel Walker <dwalker@xxxxxxxxxx>
Subject: Re: [PATCH 4/6] Replace inode flush semaphore with a completion
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 14 Aug 2008 12:30:54 +1000
Cc: xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, matthew@xxxxxx
In-reply-to: <1218677690.6166.51.camel@xxxxxxxxxxxxxxxxx>
Mail-followup-to: Daniel Walker <dwalker@xxxxxxxxxx>, xfs@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, matthew@xxxxxx
References: <1214556284-4160-1-git-send-email-david@xxxxxxxxxxxxx> <1214556284-4160-5-git-send-email-david@xxxxxxxxxxxxx> <1218597077.6166.15.camel@xxxxxxxxxxxxxxxxx> <20080813075057.GZ6119@disturbed> <1218641641.6166.32.camel@xxxxxxxxxxxxxxxxx> <20080814001938.GC6119@disturbed> <1218677690.6166.51.camel@xxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Aug 13, 2008 at 06:34:49PM -0700, Daniel Walker wrote:
> On Thu, 2008-08-14 at 10:19 +1000, Dave Chinner wrote:
> > *However*, given that we already have this exact state in the
> > completion itself, I see little reason for adding the additional
> > locking overhead and the complexity of race conditions of keeping
> > this state coherent with the completion. Modifying the completion
> > API slightly to export this state is the simplest, easiest solution
> > to the problem....
> > 
> 
> I'm not suggesting anything concrete at this point, I'm just thinking
> about it.
> 
> If you assume that most of the time your doing async flushing, you
> wouldn't often need to do blocking on the completion .. Another way of
> doing it would be drop the completion most of the time, and just use the
> flag.

I don't think that will work, either - the internal completion
counter must stay in sync so there must be a wait_for_completion()
call for every complete() call. If we make the wait_for_completion()
conditional, then we have to do the same thing for the complete()
call, and that introduces complexity and potential races because the
external flag and the completion cannot be updated atomically....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>