[Top] [All Lists]

Re: [PATCH 1/6] XFS: move sync code to its own file

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/6] XFS: move sync code to its own file
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 13 Aug 2008 10:01:29 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1218505571-27588-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1218505571-27588-1-git-send-email-david@xxxxxxxxxxxxx> <1218505571-27588-2-git-send-email-david@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Aug 12, 2008 at 11:46:06AM +1000, Dave Chinner wrote:
> The sync code in XFS is spread around several files.
> While it used to make sense to have such a distribution,
> the code about to be cleaned up and so centralising it
> in one spot as the first step mackes sense.

Besides the move you also change xfs_quiesce_fs to call xfs_sync instead
of xfs_syncsub.  This does and additional XFS_QM_DQSYNC and an
xfs_filestream_flush.  The latter doesn't have any effect because we
don't have SYNC_IOWAIT set here, but the former means we are now doing
a synchronous quota sync.  I don't think that can be harmful, but I'd be
better left for a separate and properly documented patch.

Otherwise this looks good to me.

<Prev in Thread] Current Thread [Next in Thread>