xfs
[Top] [All Lists]

Re: [PATCH] XFS: factor xfs_iget_core() into hit and miss cases

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] XFS: factor xfs_iget_core() into hit and miss cases
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 13 Aug 2008 09:56:22 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1218505965-30229-1-git-send-email-david@xxxxxxxxxxxxx>
References: <1218505965-30229-1-git-send-email-david@xxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Aug 12, 2008 at 11:52:45AM +1000, Dave Chinner wrote:
> There are really two cases in xfs_iget_core(). The first is the
> cache hit case, the second is the miss case. They share very little
> code, and hence can easily be factored out into separate functions.
> This makes the code much easier to understand and subsequently
> modify.

Looks good.


<Prev in Thread] Current Thread [Next in Thread>