xfs
[Top] [All Lists]

Re: commit messages wrong in XFS git -master tree....

To: lachlan@xxxxxxx
Subject: Re: commit messages wrong in XFS git -master tree....
From: Stuart Rowan <strr-debian@xxxxxxxxxxxxxxxxxx>
Date: Tue, 12 Aug 2008 09:23:38 +0100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <48A148BE.6080406@xxxxxxx>
References: <20080812005758.GJ6119@disturbed> <48A148BE.6080406@xxxxxxx>
Reply-to: strr-debian@xxxxxxxxxxxxxxxxxx
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Thunderbird 2.0.0.16 (X11/20080723)
<tongue in cheek>
Presumably the tedious process will teach the hasty committer a valuable lesson.

Alternatively, how about a more robust TAKE process? :-)
</tongue in cheek>

My thanks to all of you, at SGI and elsewhere, for the great work; it's been a real pleasure using XFS these last few months on our NFS server.

All the best,
Stu.

Lachlan McIlroy wrote, on 12/08/08 09:24:
Sorry the commits are screwed up - looks like the committer
was a little too hasty.

To fix these up you do realise this means undoing the mods
from ptools, checking them in again and then merging them back
into OSS?  It's a bit of work for us.  How much do you really
want these fixed?

Dave Chinner wrote:
SGI folks,

The commit messages for a couple of patches has been screwed
up. The patch series I sent titled:

[PATCH 1/3] XFS: Avoid directly referencing the VFS inode
[PATCH 2/3] XFS: kill shouty XFS_ITOV_NULL macro
[PATCH 3/3] XFS: Kill shouty XFS_ITOV() macro

Is the one that I've noticed. Patch 2/3 has the commit message
for patch 1/3 instead of the correct one. Patch 1/3 has a corrupt
version of it's commit message.

Can someone please fix this up?

And can ppl be more careful when committing patches in future
and make sure they get the commit messages correct?

Cheers,

Dave.




<Prev in Thread] Current Thread [Next in Thread>