[Top] [All Lists]

Re: TAKE 981498 - use KM_MAYFAIL in xfs_mountfs

To: Bhagi rathi <jahnu77@xxxxxxxxx>
Subject: Re: TAKE 981498 - use KM_MAYFAIL in xfs_mountfs
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 8 Aug 2008 10:31:47 +1000
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, Lachlan McIlroy <lachlan@xxxxxxx>, sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <cc7060690808071023r6b29d6c0k9240eb677e78524e@xxxxxxxxxxxxxx>
Mail-followup-to: Bhagi rathi <jahnu77@xxxxxxxxx>, Eric Sandeen <sandeen@xxxxxxxxxxx>, Lachlan McIlroy <lachlan@xxxxxxx>, sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
References: <20080806054121.CB2F258C52A4@xxxxxxxxxxxxxxxxxxxxxxx> <cc7060690808061022i1dce01dfx9e43ad3a75e5c936@xxxxxxxxxxxxxx> <489A01B0.5050606@xxxxxxxxxxx> <20080806202256.GR21635@disturbed> <cc7060690808071023r6b29d6c0k9240eb677e78524e@xxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Aug 07, 2008 at 10:53:55PM +0530, Bhagi rathi wrote:
> On Thu, Aug 7, 2008 at 1:52 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
> > On Wed, Aug 06, 2008 at 02:55:28PM -0500, Eric Sandeen wrote:
> > > Bhagi rathi wrote:
> > > > Why are we going to block for ever? Mounting a file-system
> > > > requires in-core log space buffers, reading of other buffers
> > > > which needs allocation of memory greater than per ag
> > > > structures.
> > .....
> > > In general KM_MAYFAIL sounds like a good plan when you can handle the
> > > failure gracefully, I think.
> >
> > Yes, and that is the long term plan - to remove all KM_SLEEP
> > allocations from XFS and allow them to fail gracefully. There's
> > lots of work needed before we get there, though. e.g.
> > right now we cannot survive an ENOMEM error in a transaction....
>  I am not sure that we are solving right problem. Isn't the above is
> fall-out
>  of XFS needing memory to clean dirty memory?

We can't avoid that. It is inherent in the design of XFS.  And the
amount of memory is not easily bounded so existing solutions like
wrapping slabs in mempools don't work, either.

>  That is of good priority
>  to engineer than this handling of ENOMEM in transactions.

That's just one example of an extremely non-trivial piece of work
that needs to be done to allow all memory allocations to fail.
This work will be done for other reasons (like transaction
rollback to prevent shutdowns on errors inside a dirty
transaction), not specifically to allow memory allocations
to fail.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>