Re: TAKE 981498 - use KM_MAYFAIL in xfs_mountfs

["Bhagi rathi" <jahnu77@xxxxxxxxx>]

On Thu, Aug 7, 2008 at 1:52 AM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:

> On Wed, Aug 06, 2008 at 02:55:28PM -0500, Eric Sandeen wrote:
> > Bhagi rathi wrote:
> > > Why are we going to block for ever? Mounting a file-system
> > > requires in-core log space buffers, reading of other buffers
> > > which needs allocation of memory greater than per ag
> > > structures.
> .....
> > In general KM_MAYFAIL sounds like a good plan when you can handle the
> > failure gracefully, I think.
>
> Yes, and that is the long term plan - to remove all KM_SLEEP
> allocations from XFS and allow them to fail gracefully. There's
> lots of work needed before we get there, though. e.g.
> right now we cannot survive an ENOMEM error in a transaction....


 I am not sure that we are solving right problem. Isn't the above is
fall-out
 of XFS needing memory to clean dirty memory? That is of good priority
 to engineer than this handling of ENOMEM in transactions.


Cheers,
Bhagi.


>
>
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@xxxxxxxxxxxxx
>


[[HTML alternate version deleted]]