Re: TAKE 981498 - use KM_MAYFAIL in xfs_mountfs

["Bhagi rathi" <jahnu77@xxxxxxxxx>]

On Thu, Aug 7, 2008 at 1:25 AM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:

> Bhagi rathi wrote:
> > Why are we going to block for ever? Mounting a file-system
> > requires in-core log space buffers, reading of other buffers
> > which needs allocation of memory greater than per ag
> > structures.
> >
> > I am trying to understand why xfs_perag_t? Mount/Unmount
> > are not frequent activities, it is better for them to succeed
> > if operating system can allocate memory and take them
> > forward.
>
> But that's the big if, right?
>
> If the system is so starved that you can't get this memory to even start
> the mount process, I'm sure it's better to fail the mount with -ENOMEM
> than to add to the current system memory stress.


 Not really. It is going to fail many automated scripts.  We are designing
 for a problem that system  is starved with memory. It points to a bug
 in memory & system dirty state cleaning, they are the ideal problems
 to be solved this instead of this.  As long as system recovers, it is  good
 not to disturb automated scripts by introducing these kind of  unnecessary
 failures of the mount command.



>
>
> In general KM_MAYFAIL sounds like a good plan when you can handle the
> failure gracefully, I think.


 Not really. It fails mount gracefully, however, it needs administrative
action.
 It is expected that operating system will recover and functional without
 admin intervention.

Cheers,
Bhagi.

>
>
> -Eric
>


[[HTML alternate version deleted]]