xfs
[Top] [All Lists]

Re: TAKE 981498 - use KM_MAYFAIL in xfs_mountfs

To: "Lachlan McIlroy" <lachlan@xxxxxxx>
Subject: Re: TAKE 981498 - use KM_MAYFAIL in xfs_mountfs
From: "Bhagi rathi" <jahnu77@xxxxxxxxx>
Date: Wed, 6 Aug 2008 22:52:38 +0530
Cc: sgi.bugs.xfs@xxxxxxxxxxxx, xfs@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=24q5A6b9S0FYMxRmAAnqG8biWTe0WdsP2IgVJGF0wDk=; b=ELTVHHU4WTxpuel3InfBaAZIU4hvcIkxWxEkKxxD5ymv7n5dCt+bZEAJrzKUx5ONc7 7R/sFdD5sVldBroBWj8TEBcu/4WvzWfkXeZ2q7xOEDxpDPW7XBeGv7yvvLeycXic5Fsl fz9fyvgWam6LPO6oHaKemqS2Bw/b1jwS1Gn1Q=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=spncBunkRR/OMS3i54AoXry1UUghrA4Fs/38C9Nfhj+dLxIDJ/F8MQVZFpPks1HkQ/ g5dOkh9ZuGAyMJwhGl/SSMIByZFFYTGdg7ezYAP9zZfEsjyO8gApd+1i1OT5/1Z3pB17 uGqVv4BVVDpGloc/j2orJad3Z8+1U4PxcyZfE=
In-reply-to: <20080806054121.CB2F258C52A4@xxxxxxxxxxxxxxxxxxxxxxx>
References: <20080806054121.CB2F258C52A4@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
Why are we going to block for ever? Mounting a file-system
requires in-core log space buffers, reading of other buffers
which needs allocation of memory greater than per ag
structures.

I am trying to understand why xfs_perag_t? Mount/Unmount
are not frequent activities, it is better for them to succeed
if operating system can allocate memory and take them
forward.

-Saradhi.

On Wed, Aug 6, 2008 at 11:11 AM, Lachlan McIlroy <lachlan@xxxxxxx> wrote:

> use KM_MAYFAIL in xfs_mountfs
>
> Use KM_MAYFAIL for the m_perag allocation, we can deal with the error
> easily and blocking forever during mount is not a good idea either.
>
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> Date:  Wed Aug  6 15:40:44 AEST 2008
> Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-mm
> Inspected by:
> hch
> lachlan
> Author:  lachlan
>
> The following file(s) were checked into:
>  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
>
>
> Modid:  xfs-linux-melb:xfs-kern:31837a
> fs/xfs/xfs_mount.c - 1.445 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/> 
xfs_mount.c.diff?r1=text&tr1=1.445&r2=text&tr2=1.444&f=h
>
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c.diff?r1=text&tr1=1.445&r2=text&tr2=1.444&f=h
>        - use KM_MAYFAIL in xfs_mountfs
>
>
>
>
>


[[HTML alternate version deleted]]


<Prev in Thread] Current Thread [Next in Thread>