Re: TAKE 981498 - use KM_MAYFAIL in xfs_mountfs

["Bhagi rathi" <jahnu77@xxxxxxxxx>]

Why are we going to block for ever? Mounting a file-system
requires in-core log space buffers, reading of other buffers
which needs allocation of memory greater than per ag
structures.

I am trying to understand why xfs_perag_t? Mount/Unmount
are not frequent activities, it is better for them to succeed
if operating system can allocate memory and take them
forward.

-Saradhi.

On Wed, Aug 6, 2008 at 11:11 AM, Lachlan McIlroy <lachlan@xxxxxxx> wrote:

> use KM_MAYFAIL in xfs_mountfs
>
> Use KM_MAYFAIL for the m_perag allocation, we can deal with the error
> easily and blocking forever during mount is not a good idea either.
>
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
>
> Date:  Wed Aug  6 15:40:44 AEST 2008
> Workarea:  redback.melbourne.sgi.com:/home/lachlan/isms/2.6.x-mm
> Inspected by:
> hch
> lachlan
> Author:  lachlan
>
> The following file(s) were checked into:
>  longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
>
>
> Modid:  xfs-linux-melb:xfs-kern:31837a
> fs/xfs/xfs_mount.c - 1.445 - changed
http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/> 
xfs_mount.c.diff?r1=text&tr1=1.445&r2=text&tr2=1.444&f=h
>
> http://oss.sgi.com/cgi-bin/cvsweb.cgi/xfs-linux/xfs_mount.c.diff?r1=text&tr1=1.445&r2=text&tr2=1.444&f=h
>        - use KM_MAYFAIL in xfs_mountfs
>
>
>
>
>


[[HTML alternate version deleted]]