| To: | Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 00/26] generic btree implementation, version 3 |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Tue, 5 Aug 2008 02:49:24 +0200 |
| In-reply-to: | <20080804015425.GE6119@disturbed> |
| References: | <20080804013158.GA8819@xxxxxx> <20080804015425.GE6119@disturbed> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
On Mon, Aug 04, 2008 at 11:54:25AM +1000, Dave Chinner wrote: > > The alloc and inobt trees were in fact using the almost exact sequence > > built from ->set_root and ->free_block but the odd way to pass the > > block to be freed made this non-obvious. By changing the calling > > convention to the normal one this one could be unified. I've left > > in some nasty asserts to ensure the assumptions about these blocks > > wasn't wrong. > > Ok. I'll comment on it when the patches come through.... The killroot unification turned out to be buggy, I'll fix it in the next round of patches. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 00/26] generic btree implementation, version 3, Dave Chinner |
|---|---|
| Next by Date: | Re: [PATCH 20/26] move xfs_bmbt_newroot to common code, Dave Chinner |
| Previous by Thread: | Re: [PATCH 00/26] generic btree implementation, version 3, Dave Chinner |
| Next by Thread: | [PATCH 01/26] kill struct xfs_btree_hdr, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |