xfs
[Top] [All Lists]

Re: [PATCH 13/21] implement generic xfs_btree_update

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 13/21] implement generic xfs_btree_update
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 2 Aug 2008 11:15:23 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080801194624.GG1263@xxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
References: <20080729193116.GN19104@xxxxxx> <20080730052959.GN13395@disturbed> <20080801194624.GG1263@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Aug 01, 2008 at 09:46:24PM +0200, Christoph Hellwig wrote:
> On Wed, Jul 30, 2008 at 03:29:59PM +1000, Dave Chinner wrote:
> > Oh, it's be moved inside the update code itself. So, why always call
> > the update function and then check the ptr? Why not the way it was
> > originally done?
> 
> Because all three callers do different checks, and I could not proof
> that they are either identical or hamrless for the other cases.
> We can clean this mess up later in small standalone patches.

Ok. Sounds like a good plan.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>