xfs
[Top] [All Lists]

Re: [PATCH 12/21] implement generic xfs_btree_updkey

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 12/21] implement generic xfs_btree_updkey
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 2 Aug 2008 11:14:42 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080801194452.GF1263@xxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
References: <20080729193110.GM19104@xxxxxx> <20080730050936.GM13395@disturbed> <20080801194452.GF1263@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Aug 01, 2008 at 09:44:52PM +0200, Christoph Hellwig wrote:
> On Wed, Jul 30, 2008 at 03:09:36PM +1000, Dave Chinner wrote:
> > And even then I think we might not need an error variable - it can
> > only return EFSCORRUPTED, so:
> > 
> > #ifdef DEBUG
> >             if (xfs_btree_check_block(cur, block, level, bp)) {
> >                     XFS_BTREE_TRACE_CURSOR(cur, XBT_ERROR);
> >                     return EFSCORRUPTED;
> >             }
> > #endif
> > 
> > Would remove the need for the error variable.
> 
> I'm not a big fan of losing detailed error information.  Depending
> on how the bigger btree blocks work out we might return other errors
> here in the near future.

Fair enough.

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>