xfs
[Top] [All Lists]

Re: [PATCH 11/21] implement generic xfs_btree_lookup

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 11/21] implement generic xfs_btree_lookup
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 2 Aug 2008 11:14:00 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080801194336.GE1263@xxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
References: <20080729193104.GL19104@xxxxxx> <20080730045937.GL13395@disturbed> <20080801194336.GE1263@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Aug 01, 2008 at 09:43:36PM +0200, Christoph Hellwig wrote:
> On Wed, Jul 30, 2008 at 02:59:37PM +1000, Dave Chinner wrote:
> > > --- linux-2.6-xfs.orig/fs/xfs/xfs_alloc.c 2008-07-15 17:46:52.000000000 
> > > +0200
> > > +++ linux-2.6-xfs/fs/xfs/xfs_alloc.c      2008-07-15 17:51:41.000000000 
> > > +0200
> > > @@ -90,6 +90,54 @@ STATIC int xfs_alloc_ag_vextent_small(xf
> > >   */
> > >  
> > >  /*
> > > + * Lookup the record equal to [bno, len] in the btree given by cur.
> > > + */
> > > +STATIC int                               /* error */
> > > +xfs_alloc_lookup_eq(
> > 
> > Should these be xfs_allocbt_lookup_*() to be consistent
> > with all the other allocbt functions (and inobt_lookup/bmbt_lookup)?
> 
> Currently only the btree_ops methods are named allocbt.  Comments on
> that scheme would be appreciated.

I think I used 'abt' for it. Perhaps 'albt'? allocbt is probably ok,
though, just longer.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>