xfs
[Top] [All Lists]

Re: [PATCH 21/21] clean up xfs_bmap_btree.c

To: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 21/21] clean up xfs_bmap_btree.c
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 1 Aug 2008 21:55:56 +0200
In-reply-to: <20080730073245.GV13395@disturbed>
References: <20080729193200.GV19104@xxxxxx> <20080730073245.GV13395@disturbed>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Wed, Jul 30, 2008 at 05:32:45PM +1000, Dave Chinner wrote:
> > +   ASSERT(nrecs == crecs);
> > +   kp = xfs_bmbt_key_addr(cur, 1, block);
> > +   ckp = xfs_bmbt_key_addr(cur, 1, cblock);
> > +   memcpy(kp, ckp, nrecs * sizeof(xfs_bmbt_key_t));
> 
> Should really be xfs_bmbt_copy_keys(), right?

Yes, fixed.

> > +   memcpy(pp, cpp, nrecs * sizeof(xfs_bmbt_key_t));
> 
> xfs_bmbt_copy_recs()?

Yes, fixed.


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 21/21] clean up xfs_bmap_btree.c, Christoph Hellwig <=