xfs
[Top] [All Lists]

Re: [PATCH 08/21] make btree tracing generic

To: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 08/21] make btree tracing generic
From: Christoph Hellwig <hch@xxxxxx>
Date: Fri, 1 Aug 2008 21:36:25 +0200
In-reply-to: <20080730013920.GI13395@disturbed>
References: <20080729193044.GI19104@xxxxxx> <20080730013920.GI13395@disturbed>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Wed, Jul 30, 2008 at 11:39:20AM +1000, Dave Chinner wrote:
> > +   void            (*trace_enter)(struct xfs_btree_cur *, const char *,
> > +                                  char *, int, int, __psunsigned_t,
> > +                                  __psunsigned_t, __psunsigned_t,
> > +                                  __psunsigned_t, __psunsigned_t,
> > +                                  __psunsigned_t, __psunsigned_t,
> > +                                  __psunsigned_t, __psunsigned_t,
> > +                                  __psunsigned_t, __psunsigned_t);
> 
> Would it be better to use a 'trace args' structure here rather
> than passing a heap of parameters? memset(args, 0,...) rather than
> passing a whole heap of zeros in most cases seems like a better
> approach to me, esp. as they all get cast to (void *) anyway....

Well, we need to case to void * somewhere, and going from struct
to arguments list isn't helpful either.

Changing the whole ktrace thing to an args strucutr and/or varags
would be nice, but is not in scope for this patchset..

> > +static void
> > +xfsidb_btree_trace_record(
> 
> shouldn't these all use "xfsidbg" prefixes?

Probably.


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 08/21] make btree tracing generic, Christoph Hellwig <=