xfs
[Top] [All Lists]

Re: TAKE 985525 - Fix use after free in xfs_log_done().

To: linux-xfs@xxxxxxxxxxx, lachlan@xxxxxxx
Subject: Re: TAKE 985525 - Fix use after free in xfs_log_done().
From: Martin Steigerwald <Martin@xxxxxxxxxxxx>
Date: Thu, 14 Aug 2008 13:21:22 +0200
In-reply-to: <48A38550.4030102@sgi.com>
References: <20080812044629.B2DE858C52A4@chook.melbourne.sgi.com> <200808131115.03350.Martin@lichtvoll.de> <48A38550.4030102@sgi.com> (sfid-20080814_131859_502892_BDBAE707)
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: KMail/1.9.9
Am Donnerstag 14 August 2008 schrieb Lachlan McIlroy:
> Martin Steigerwald wrote:
> > Am Dienstag 12 August 2008 schrieb Martin Steigerwald:
> >> Am Dienstag 12 August 2008 schrieb Lachlan McIlroy:
> >>> Fix use after free in xfs_log_done().
> >>>
> >>> The ticket allocation code got reworked in 2.6.26 and we now free
> >>> tickets whereas before we used to cache them so the use-after-free
> >>> went undetected.
> >>
> >> Is this intended to go to stable tree?
> >>
> >> How serious is this? I intend to update my laptops to 2.6.26.
> >
> > Nevermind, I just applied the patch.
>
> Okay.
>
> We've only seen this bug once and I'm surprised it happened at all
> so I wouldn't consider it a serious problem.

The fix appears to be trivial, so it might still be a good patch for 
stable tree. So far all runs well on my IBM ThinkPads T42 and T23 with 
2.6.26.2, tuxonice 3.0rc7a and that patch.

-- 
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA  B82F 991B EAAC A599 84C7


<Prev in Thread] Current Thread [Next in Thread>