| To: | Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 1/3] Implement generic freeze feature |
| From: | Andreas Dilger <adilger@xxxxxxx> |
| Date: | Fri, 22 Aug 2008 01:09:58 -0600 |
| Cc: | Takashi Sato <t-sato@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx, axboe@xxxxxxxxx, mtk.manpages@xxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <20080821125841.a04a706f.akpm@linux-foundation.org> |
| References: | <20080818212819t-sato@mail.jp.nec.com> <20080821125841.a04a706f.akpm@linux-foundation.org> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Aug 21, 2008 12:58 -0700, Andrew Morton wrote:
> > #define FIGETBSZ _IO(0x00,2) /* get the block size used for bmap */
> > +#define FIFREEZE _IOWR('X', 119, int) /* Freeze */
> > +#define FITHAW _IOWR('X', 120, int) /* Thaw */
>
> FIFREEZE is 119, but a few lines above we have
>
> #define BLKDISCARD _IO(0x12,119)
>
> Should we be using 120 and 121 here?
No, because 'X' != 0x12... The 'X' is used because this ioctl is compatible
with the XFS implementation of this feature.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: XFS vs Elevators (was Re: [PATCH RFC] nilfs2: continuous snapshotting file system), Martin Steigerwald |
|---|---|
| Next by Date: | XFS issue under 2.6.25.13 kernel, Sławomir Nowakowski |
| Previous by Thread: | Re: [PATCH 1/3] Implement generic freeze feature, Andrew Morton |
| Next by Thread: | Re: [PATCH 1/3] Implement generic freeze feature, Takashi Sato |
| Indexes: | [Date] [Thread] [Top] [All Lists] |