Re: TAKE 981498 - Use xfs_idestroy() to cleanup an inode.

[Lachlan McIlroy <lachlan@xxxxxxx>]

This change was part of another patch that you reviewed.  This small
change got left out when I merged my changes in with your inode
allocation cleanup which you asked me to do.  I also had to modify
your original patch because it did not apply cleanly due other changes
that you made (the semaphore completion stuff).  I didn't have to take
your cleanup patch - I could have just fixed the bug.  So in amongst
your complaining I'll assume there is a covert "thanks for taking my
patch".


Dave Chinner wrote:
> On Wed, Aug 20, 2008 at 01:33:02PM +1000, Lachlan McIlroy wrote:
> > Use xfs_idestroy() to cleanup an inode.
>
> I'm not sure what has been checked in this patch, even though it's
> recorded that I reviewed it. Yes, I reviewed the original patch, but
> I asked for changes to be made. I *haven't reviewed* what got
> checked in.
>
> With the changelog being entirely useless - not even mentioning it
> fixes a memory leak or a deadlock - I have no idea what changes were
> made in response to my initial review.  I now have to wait for CVS
> or git to be updated before being able to find out what just got
> checked in so I can review it.
>
> Lachlan (and for everyone else @ sgi), in future if someone in the
> community reviews a patch and asks for change, can you please repost
> the modified patches to close the review cycle before anything is
> checked in?
>
> Cheers,
>
> Dave.