Re: [PATCH 1/6] XFS: move sync code to its own file

[Christoph Hellwig <hch@xxxxxxxxxxxxx>]

On Tue, Aug 12, 2008 at 11:46:06AM +1000, Dave Chinner wrote:
> The sync code in XFS is spread around several files.
> While it used to make sense to have such a distribution,
> the code about to be cleaned up and so centralising it
> in one spot as the first step mackes sense.

Besides the move you also change xfs_quiesce_fs to call xfs_sync instead
of xfs_syncsub.  This does and additional XFS_QM_DQSYNC and an
xfs_filestream_flush.  The latter doesn't have any effect because we
don't have SYNC_IOWAIT set here, but the former means we are now doing
a synchronous quota sync.  I don't think that can be harmful, but I'd be
better left for a separate and properly documented patch.

Otherwise this looks good to me.