| To: | Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx |
|---|---|
| Subject: | Re: [PATCH 21/21] clean up xfs_bmap_btree.c |
| From: | Christoph Hellwig <hch@xxxxxx> |
| Date: | Fri, 1 Aug 2008 21:55:56 +0200 |
| In-reply-to: | <20080730073245.GV13395@disturbed> |
| References: | <20080729193200.GV19104@lst.de> <20080730073245.GV13395@disturbed> |
| Sender: | xfs-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.3.28i |
On Wed, Jul 30, 2008 at 05:32:45PM +1000, Dave Chinner wrote: > > + ASSERT(nrecs == crecs); > > + kp = xfs_bmbt_key_addr(cur, 1, block); > > + ckp = xfs_bmbt_key_addr(cur, 1, cblock); > > + memcpy(kp, ckp, nrecs * sizeof(xfs_bmbt_key_t)); > > Should really be xfs_bmbt_copy_keys(), right? Yes, fixed. > > + memcpy(pp, cpp, nrecs * sizeof(xfs_bmbt_key_t)); > > xfs_bmbt_copy_recs()? Yes, fixed. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 17/21] implement generic xfs_btree_split, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 2/3] optimize xfs_ichgtime, Christoph Hellwig |
| Previous by Thread: | Re: [PATCH 17/21] implement generic xfs_btree_split, Christoph Hellwig |
| Next by Thread: | Re: [PATCH 2/3] optimize xfs_ichgtime, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |