xfs
[Top] [All Lists]

[PATCH 3/6] xfs_unmountfs should return void

To: xfs@xxxxxxxxxxx
Subject: [PATCH 3/6] xfs_unmountfs should return void
From: Christoph Hellwig <hch@xxxxxx>
Date: Sat, 26 Jul 2008 11:57:10 +0200
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
xfs_unmounts can't and shouldn't return errors so declare it as
returning void.


Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: linux-2.6-xfs/fs/xfs/xfs_mount.c
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/xfs_mount.c       2008-07-26 09:27:41.000000000 
+0200
+++ linux-2.6-xfs/fs/xfs/xfs_mount.c    2008-07-26 09:27:43.000000000 +0200
@@ -1229,16 +1229,15 @@ xfs_mountfs(
 }
 
 /*
- * xfs_unmountfs
- *
  * This flushes out the inodes,dquots and the superblock, unmounts the
  * log and makes sure that incore structures are freed.
  */
-int
-xfs_unmountfs(xfs_mount_t *mp)
+void
+xfs_unmountfs(
+       struct xfs_mount        *mp)
 {
-       __uint64_t      resblks;
-       int             error = 0;
+       __uint64_t              resblks;
+       int                     error;
 
        IRELE(mp->m_rootip);
 
@@ -1311,7 +1310,6 @@ xfs_unmountfs(xfs_mount_t *mp)
        xfs_errortag_clearall(mp, 0);
 #endif
        xfs_mount_free(mp);
-       return 0;
 }
 
 STATIC void
Index: linux-2.6-xfs/fs/xfs/xfs_mount.h
===================================================================
--- linux-2.6-xfs.orig/fs/xfs/xfs_mount.h       2008-07-26 09:27:41.000000000 
+0200
+++ linux-2.6-xfs/fs/xfs/xfs_mount.h    2008-07-26 09:27:43.000000000 +0200
@@ -511,7 +511,7 @@ extern int  xfs_log_sbcount(xfs_mount_t *
 extern int     xfs_mountfs(xfs_mount_t *mp);
 extern void    xfs_mountfs_check_barriers(xfs_mount_t *mp);
 
-extern int     xfs_unmountfs(xfs_mount_t *);
+extern void    xfs_unmountfs(xfs_mount_t *);
 extern int     xfs_unmountfs_writesb(xfs_mount_t *);
 extern int     xfs_unmount_flush(xfs_mount_t *, int);
 extern int     xfs_mod_incore_sb(xfs_mount_t *, xfs_sb_field_t, int64_t, int);


<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 3/6] xfs_unmountfs should return void, Christoph Hellwig <=