xfs
[Top] [All Lists]

Re: [PATCH 1/3] update timestamp in xfs_ialloc manually

To: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 1/3] update timestamp in xfs_ialloc manually
From: Christoph Hellwig <hch@xxxxxx>
Date: Sat, 26 Jul 2008 11:14:59 +0200
In-reply-to: <20080726090725.GR5947@disturbed>
References: <20080726063331.GA22603@xxxxxx> <20080726090725.GR5947@disturbed>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Sat, Jul 26, 2008 at 07:07:25PM +1000, Dave Chinner wrote:
> On Sat, Jul 26, 2008 at 08:33:31AM +0200, Christoph Hellwig wrote:
> > In xfs_ialloc we just want to set all timestamps to the current time.
> > We don't need to mark the inode dirty like xfs_ichgtime does, and we
> > don't need nor want the opimizations in xfs_ichgtime that I will
> > introduce in the next patch.
> 
> Looks sane, and solves an issue with code I'm working on, too.
> 
> FWIW, the conditional check against I_NEW before marking the
> indo dirty can be removed as well, as this was call that required
> avoiding avoiding it.

Yeah.  Will update and retest the patch.


<Prev in Thread] Current Thread [Next in Thread>