xfs
[Top] [All Lists]

Re: [PATCH 3/3] stop using file_update_time

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 3/3] stop using file_update_time
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 26 Jul 2008 19:13:48 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080726063339.GC22603@xxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
References: <20080726063339.GC22603@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Jul 26, 2008 at 08:33:39AM +0200, Christoph Hellwig wrote:
> xfs_ichtime updates the xfs_inode and Linux inode timestamps just fine,
> no need to call file_update_time and then copy the values over to the
> XFS inode.  The only additional thing in file_update_time are checks
> not applicable to the write path.
.....

> Index: linux-2.6-xfs/fs/xfs/linux-2.6/xfs_iops.h
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/linux-2.6/xfs_iops.h    2008-07-24 
> 08:37:09.000000000 +0200
> +++ linux-2.6-xfs/fs/xfs/linux-2.6/xfs_iops.h 2008-07-24 08:37:40.000000000 
> +0200
> @@ -26,9 +26,6 @@ extern const struct file_operations xfs_
>  
>  extern ssize_t xfs_vn_listxattr(struct dentry *, char *data, size_t size);
>  
> -extern void xfs_ichgtime(struct xfs_inode *, int);
> -extern void xfs_ichgtime_fast(struct xfs_inode *, struct inode *, int);
> -

I don't think you meant to remove the xfs_ichgtime() prototype
as well...

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx


<Prev in Thread] Current Thread [Next in Thread>