[Top] [All Lists]

Re: [PATCH 1/3] update timestamp in xfs_ialloc manually

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH 1/3] update timestamp in xfs_ialloc manually
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sat, 26 Jul 2008 19:07:25 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20080726063331.GA22603@xxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxx>, xfs@xxxxxxxxxxx
References: <20080726063331.GA22603@xxxxxx>
Sender: xfs-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
On Sat, Jul 26, 2008 at 08:33:31AM +0200, Christoph Hellwig wrote:
> In xfs_ialloc we just want to set all timestamps to the current time.
> We don't need to mark the inode dirty like xfs_ichgtime does, and we
> don't need nor want the opimizations in xfs_ichgtime that I will
> introduce in the next patch.

Looks sane, and solves an issue with code I'm working on, too.

FWIW, the conditional check against I_NEW before marking the
indo dirty can be removed as well, as this was call that required
avoiding avoiding it.


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>